Skip to content

Conversation

@uranusjr
Copy link
Member

This adds a CI step for PRs with the label airflow3.0:breaking and ensure they include a news fragment.

@uranusjr uranusjr requested review from ashb, kaxil and potiuk as code owners August 13, 2024 18:40
@uranusjr uranusjr added the airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes label Aug 13, 2024
@uranusjr uranusjr force-pushed the require-news-fragment branch from 4b8f2b8 to 1c3429f Compare August 13, 2024 18:46
@uranusjr uranusjr force-pushed the require-news-fragment branch 2 times, most recently from 5a5e326 to d5ab960 Compare August 13, 2024 18:54
@uranusjr uranusjr force-pushed the require-news-fragment branch 5 times, most recently from a09f36b to d7dd711 Compare August 13, 2024 19:11
@uranusjr uranusjr removed the airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes label Aug 13, 2024
@uranusjr uranusjr force-pushed the require-news-fragment branch from d7dd711 to 50e365e Compare August 13, 2024 19:12
@uranusjr uranusjr force-pushed the require-news-fragment branch from 50e365e to 0c86122 Compare August 13, 2024 19:14
@uranusjr uranusjr added airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes and removed airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes labels Aug 13, 2024
@uranusjr
Copy link
Member Author

Finally figured this out; should be mergable after CI.

@uranusjr uranusjr added the airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes label Aug 13, 2024
@uranusjr uranusjr force-pushed the require-news-fragment branch 2 times, most recently from 896ee69 to baf85ae Compare August 13, 2024 22:51
@uranusjr uranusjr removed the airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes label Aug 13, 2024
@uranusjr uranusjr force-pushed the require-news-fragment branch from baf85ae to 3d6109d Compare August 13, 2024 22:53
@uranusjr uranusjr merged commit 509f15e into apache:main Aug 14, 2024
@uranusjr uranusjr deleted the require-news-fragment branch August 14, 2024 01:45
@uranusjr
Copy link
Member Author

I’m going to have this in main first and worry about improvements (might not be that much needed anyway) later.

@vincbeck
Copy link
Contributor

This test is failing in #41434 although there is one newsfragment

@uranusjr
Copy link
Member Author

There’s Checks SKIPPED: news file changes detected. so a file was found, but the test still failed. I think we’re using the conditions wrong…

Artuz37 pushed a commit to Artuz37/airflow that referenced this pull request Aug 19, 2024
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants