Fix try selector refresh #41483
Merged
Fix try selector refresh #41483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbovenzi
requested review from
ashb,
pierrejeambrun and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:UI
jscheffl
approved these changes
Aug 14, 2024
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Can confirm this PR fixes the inconsistency. Also less code so +2 LGTM :-)
Contributor
|
...and if somebody calls for 2.10.0.rc2 then we have a chance to cherry-pick this into as well... let's see |
jedcunningham
approved these changes
Aug 15, 2024
bbovenzi
added a commit
to astronomer/airflow
that referenced
this pull request
Aug 15, 2024
Artuz37
pushed a commit
to Artuz37/airflow
that referenced
this pull request
Aug 19, 2024
bbovenzi
added a commit
that referenced
this pull request
Aug 19, 2024
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Aug 20, 2024
utkarsharma2
pushed a commit
that referenced
this pull request
Sep 2, 2024
23 tasks
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #41462
We had two separate sources of truth on how many try numbers to show. It got messy during autorefresh. I think the TI History endpoint is good enough to rely on and use as a single source of truth.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.