Fix news fragment check conditional #41491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only want to fail the script if the 'towncrier check' call fails. The previous code always runs the '&& false' part (because the printf call always succeeds) and failed the job.
jedcunningham
approved these changes
Aug 15, 2024
Artuz37
pushed a commit
to Artuz37/airflow
that referenced
this pull request
Aug 19, 2024
We only want to fail the script if the 'towncrier check' call fails. The previous code always runs the '&& false' part (because the printf call always succeeds) and failed the job.
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Aug 20, 2024
We only want to fail the script if the 'towncrier check' call fails. The previous code always runs the '&& false' part (because the printf call always succeeds) and failed the job.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only want to fail the script if the 'towncrier check' call fails. The previous code always runs the '&& false' part (because the printf call always succeeds) and failed the job.