Field Deletion Warning when editing Connections (#41144) #41504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* able to change the 'Changed Row' display message after edit * added message in connection form to warn of empty fields * attempt to warn the specific fields cannot be empty * revert change because need to check fields before save is clicked * issues warning for specific fields that can't be deleted after save * removed the individual warnings * changed status to concise string * added more concise suggestion Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com> --------- Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com>
bbovenzi
requested review from
ashb,
pierrejeambrun and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:UI
vincbeck
approved these changes
Aug 19, 2024
utkarsharma2
added
type:improvement
utkarsharma2
pushed a commit
that referenced
this pull request
Sep 2, 2024
* able to change the 'Changed Row' display message after edit * added message in connection form to warn of empty fields * attempt to warn the specific fields cannot be empty * revert change because need to check fields before save is clicked * issues warning for specific fields that can't be deleted after save * removed the individual warnings * changed status to concise string * added more concise suggestion --------- Co-authored-by: Lucy Hu <90779522+lh5844@users.noreply.github.com>
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick for 2.10.x
#41144
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.