Refactor DataprocCreateBatchOperator and Dataproc system tests #41527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:dev-tools
area:providers
area:system-tests
provider:google
moiseenkov
force-pushed
the
dataproc/create_batch_operator/fix_logging
branch
3 times, most recently
from
8897353 to
b336671
Compare
moiseenkov
force-pushed
the
dataproc/create_batch_operator/fix_logging
branch
from
b336671 to
7092dcb
Compare
potiuk
approved these changes
Aug 16, 2024
Artuz37
pushed a commit
to Artuz37/airflow
that referenced
this pull request
Aug 19, 2024
43 tasks
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored
DataprocCreateBatchOperator:execute()method for decreasing its accumulated complexity and code duplication.batch_idparameter optional as it is supported by APIregionparameter required because (1) it is required by the API, and (2) it was already required de-facto because the operator used to raise and exception manually:raise AirflowException("Region should be set here")Also additionally slight refactored Dataproc system tests:
This PR also rolls back changes in pre-commit hook made for Dataflow system tests. From now those changes rea not needed.