add execute_sql API to fix ElasticSearchSQLHook #41537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Static checks are failing :( |
Contributor
Author
|
I think the 3 failing tests are
|
eladkal
approved these changes
Aug 17, 2024
Artuz37
pushed a commit
to Artuz37/airflow
that referenced
this pull request
Aug 19, 2024
43 tasks
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Aug 20, 2024
eladkal
reviewed
Aug 25, 2024
|
|
||
| from deprecated import deprecated | ||
| from elasticsearch import Elasticsearch | ||
| from elasticsearch.client import SqlClient |
Contributor
There was a problem hiding this comment.
This import causes deprecation warning
https://github.com/elastic/elasticsearch-py/blob/4ee46509e236bf30f540d173b48bb7650159556d/elasticsearch/client.py#L75-L80
Contributor
Author
There was a problem hiding this comment.
Indeed...We should access the SQL client directly via es instance. I'll file a PR to fix it later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41486
The current
ElasticsearchSQLHookis not working since it is still usingelasticsearch-dbapiwhich has already been deprecated last year. This PR fixes the issue by adding aexecute_sqlAPI, which simply forwards the SQL query to the underlying official elasticsearch client.Docs are also updated to show a working example of
ElasticsearchSQLHook. A Screencap of the log output: