Skip to content

Conversation

@ferruzzi
Copy link
Contributor

@ferruzzi ferruzzi commented Aug 16, 2024

backup_db_to_point_in_time_incremental_export requires at least a 15-minute window of available data, causing the system tests to fail. Moving it into a branching task group will let us keep the code snippet in the docs without actually running the task in the test.

Workaround for the issue presented in #41304. If someone wants to take on an actual fix, tag me and I'll review it, but for now I want to get the test running again. Branching operators are a bit confusing, see how we did it in the Bedrock system test (here) if you want to see some existing working examples.

TLDR of the issue:

error: "from" time can't be equal to "to" time
tried: so I set "from" to export_time - 1_minute
error: "from" can't be less than table creation time
tried: revert the above and set "to" to be latest_export_time + 1_minute
error: Difference between "from" time and "to" is less than 15 minutes
tried: revert the above and set "to" to be latest_export_time + 16_minutes
error: "to" time cannot be greater than the current time
tried: revert the above and set "to" time to utcnow()
error: this gets set at parse time and "to" time is now in the past

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

`backup_db_to_point_in_time_incremental_export` requires at least a 15-minute window of available data, causing the system tests to fail.  Moving it into a branching task group will let us keep the code snippet in the docs without actually running the task in the test.
@potiuk potiuk merged commit 8c2f563 into apache:main Aug 16, 2024
Artuz37 pushed a commit to Artuz37/airflow that referenced this pull request Aug 19, 2024
`backup_db_to_point_in_time_incremental_export` requires at least a 15-minute window of available data, causing the system tests to fail.  Moving it into a branching task group will let us keep the code snippet in the docs without actually running the task in the test.
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Aug 20, 2024
`backup_db_to_point_in_time_incremental_export` requires at least a 15-minute window of available data, causing the system tests to fail.  Moving it into a branching task group will let us keep the code snippet in the docs without actually running the task in the test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants