Skip to content

Conversation

@morokosi
Copy link
Contributor

The papermill provider was previously excluded from releasing a version compatible with Python 3.12 due to version compatibility issues with the aiohttp dependency. However, papermill version 2.6.0, which includes a fix for this issue, has now been released. By raising the minimum version to 2.6.0, we can ensure compatibility with Python 3.12.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Aug 17, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@morokosi morokosi marked this pull request as draft August 17, 2024 03:05
@morokosi morokosi marked this pull request as ready for review August 17, 2024 03:34
@potiuk potiuk merged commit 60fe8c9 into apache:main Aug 17, 2024
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 17, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@potiuk
Copy link
Member

potiuk commented Aug 17, 2024

Thanks!

@morokosi morokosi deleted the restore-papermill-python-3-12-support branch August 17, 2024 09:27
Artuz37 pushed a commit to Artuz37/airflow that referenced this pull request Aug 19, 2024
* restore python 3.12 support for papermill

* update provider_dependencies.json
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Aug 20, 2024
* restore python 3.12 support for papermill

* update provider_dependencies.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants