Skip to content

Conversation

@utkarsharma2
Copy link
Contributor

@utkarsharma2 utkarsharma2 commented Aug 19, 2024

In the following PR - #38912 we are passing location to gcloud-aio-bigquery Job init() method, which was only introduced in the 7.1.0 version of gcloud-aio-bigquery lib. Since the current min requirement in provider version 10.21.0 is >= 6.1.2. Due to this if we have a lower version then <7.1.0 of gcloud-aio-bigquery, the jobs are not canceled when we cancel the corresponding task in Airflow UI.

This PR aims at adding the pin for the right version (>=7.1.0) of gcloud-aio-bigquery dependency of apache-airflow-providers-google

@utkarsharma2 utkarsharma2 force-pushed the fix_biguqery_job_cancellation branch from 7eb0389 to 9e62d20 Compare August 19, 2024 19:39
Copy link
Contributor

@phanikumv phanikumv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need the content in dev/breeze/doc/images in this PR?

@utkarsharma2
Copy link
Contributor Author

utkarsharma2 commented Aug 20, 2024

I don't think we need the content in dev/breeze/doc/images in this PR?

Hmm looks odd, but they were generated by pre-commits hooks, let me double check it.

@eladkal
Copy link
Contributor

eladkal commented Sep 20, 2024

which was only introduced in the 7.1.0 version of gcloud-aio-bigquery lib. Since the current min requirement in provider version 10.21.0 is >= 6.1.2. Due to this if we have a lower version then <7.1.0 of gcloud-aio-bigquery, the jobs are not canceled when we cancel the corresponding task in Airflow UI.

That is fine though. If we bump to min version for every new feature it means that we always set only latest version of any library we bring. The solution to the problem you are describing is wrapping the specific feature with checking of min needed version of the upstream library.

@github-actions
Copy link

github-actions bot commented Nov 5, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Nov 5, 2024
@github-actions github-actions bot closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools area:providers provider:google Google (including GCP) related issues stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants