Skip to content

Conversation

@kev-the-dev
Copy link
Contributor

Change confirmation text page to say "Please confirm" instead of "Wait a minute" and update associated UI-level tests. As a new user to airflow, the text "Wait a minute" implied that the user should wait for some background process, whereas the intention is for the user to review the action and confirm it. This is a trivial text change, so extensive testing was not performed, as the UI tests cover the change.

closes: #41649

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Aug 21, 2024
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 21, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@bbovenzi
Copy link
Contributor

lgtm. @kev-the-dev once this is merged, do you mind cherry picking this for the v-2-10-test branch?

@bbovenzi bbovenzi added this to the Airflow 2.10.1 milestone Aug 21, 2024
@kev-the-dev
Copy link
Contributor Author

kev-the-dev commented Aug 21, 2024 via email

@bbovenzi bbovenzi merged commit a11656c into apache:main Aug 22, 2024
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 22, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

kev-the-dev added a commit to kev-the-dev/airflow that referenced this pull request Aug 22, 2024
potiuk pushed a commit that referenced this pull request Aug 22, 2024
@utkarsharma2 utkarsharma2 added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Aug 30, 2024
utkarsharma2 pushed a commit that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confirmation text "Wait a minute" is confusing

4 participants