-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Change confirmation text to "Please Confirm" #41650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
b3aa70b to
c0e4a65
Compare
|
lgtm. @kev-the-dev once this is merged, do you mind cherry picking this for the |
|
Sure, will do!
…-------- Original Message --------
On 8/21/24 5:27 PM, Brent Bovenzi wrote:
lgtm. ***@***.***(https://github.com/kev-the-dev) once this is merged, do you mind cherry picking this for the v-2-10-test branch?
—
Reply to this email directly, [view it on GitHub](#41650 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ACIP7LH42CFVA7GFAMJ4F3TZSUA3PAVCNFSM6AAAAABM4IZPB6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBTGA2DCOBSHE).
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Change confirmation text page to say "Please confirm" instead of "Wait a minute" and update associated UI-level tests. As a new user to airflow, the text "Wait a minute" implied that the user should wait for some background process, whereas the intention is for the user to review the action and confirm it. This is a trivial text change, so extensive testing was not performed, as the UI tests cover the change.
closes: #41649