Adding rel property to hyperlinks in logs #41696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoghrajesh
requested review from
ashb,
bbovenzi,
pierrejeambrun and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:UI
Contributor
|
This is just the test file. Did you mean to add it anywhere else? |
Contributor
Author
|
Yeah there are 2 commits, first adds it to airflow/www/static/js/dag/details/taskInstance/Logs/utils.ts |
Contributor
Author
|
@bbovenzi can you take a look at this one when you have some time? |
jscheffl
approved these changes
Aug 25, 2024
bbovenzi
approved these changes
Aug 26, 2024
Contributor
Author
|
We need to backport this to 2.10 branch |
amoghrajesh
added a commit
to amoghrajesh/airflow
that referenced
this pull request
Aug 27, 2024
* Adding rel property to hyperlinks in logs * fixing tests (cherry picked from commit 79db243)
jscheffl
pushed a commit
that referenced
this pull request
Aug 27, 2024
utkarsharma2
added
the
type:misc/internal
utkarsharma2
pushed a commit
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
rel="noopener noreferrer"as `target=_blank" is used to be consistent with the codebase^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.