Don't Fail LocalTaskJob on heartbeat #41704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
area:Scheduler
RNHTTR
requested changes
Aug 23, 2024
collinmcnulty
force-pushed
the
resilient-heartbeat
branch
from
a449876 to
ec184cb
Compare
Contributor
Author
|
Sorry Jed and Jarek for the incorrect notification, I messed up the rebase process and included extra changes. Now fixed. |
jscheffl
approved these changes
Aug 25, 2024
RNHTTR
approved these changes
Aug 26, 2024
jedcunningham
pushed a commit
to astronomer/airflow
that referenced
this pull request
Aug 27, 2024
* Never fail an ltj over a heartbeat * Log a warning on failed heartbeat * Avoid using f-string in log * Remove unnecessary pass statement (cherry picked from commit 6647610)
Member
|
Cherry-pick pr: #41810 |
potiuk
pushed a commit
that referenced
this pull request
Aug 28, 2024
tthompson691
left a comment
tthompson691
left a comment
There was a problem hiding this comment.
This is a long overdue improvement!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The local task job heartbeat will crash the task if it fails. This is counter to the goal of the heartbeat, which is that it's ok if the task temporarily loses connection to the DB as long as it re-establishes it within the zombie timeout.
I've used an extremely broad exception here. I'm open to something more narrow if we have a smaller error type that will still cover the problems not controllable by the Airflow code, but I think it's reasonable to use a very broad exception.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.