remove deprecated soft_fail from providers part2 #41727
Conversation
boring-cyborg
bot
added
area:core-operators
area:providers
provider:ftp
provider:http
labels
|
only flaky tests @potiuk can we merge or you prefer to re-trigger CI ? thanks |
| raise AirflowSkipException("Skipping due to soft_fail is set to True.") from e | ||
| raise | ||
|
|
||
| trigger = DateTimeTrigger(moment=target_dttm, end_from_trigger=self.end_from_trigger) |
There was a problem hiding this comment.
wouldn't this cause breaking change in Airflow 2?
#41564 is meant to extract main operators into standard provider. This provider must be supported on Airflow 2 without breaking changes
There was a problem hiding this comment.
I think we need to merge the provider PR before this one.
PRs that handle both core and providers together is really hard to navigate. We should avoid this. It just creates confusion
There was a problem hiding this comment.
my bad I did not saw that TimeDeltaSensorAsync was not using poke but directly execute ( do you know why ? )
so yes this operator is not using the soft_fail logic of the BaseSensorOperator
I just did a revert PR -> #41741
There was a problem hiding this comment.
Thank you
We can redo the removal on main branch after we release the provider
3 participants
following : #41710