Fix mocking in cncf.kubernetes tests after get_connections removal #41805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
potiuk
changed the title
The apache#41733 removed deprecated get_connections but it was still used in cncf.kubernetes tests.
potiuk
force-pushed
the
fix-failing-cncf-kubernetes-tests-after-removing-get-connections
branch
from
4391fda to
3b0068e
Compare
jscheffl
approved these changes
Aug 27, 2024
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Uuups, did not see this. Thanks for fixing behind!
vincbeck
approved these changes
Aug 27, 2024
eladkal
approved these changes
Aug 27, 2024
potiuk
deleted the
fix-failing-cncf-kubernetes-tests-after-removing-get-connections
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #41733 removed deprecated get_connections but it was still used in cncf.kubernetes tests.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.