Skip to content

Conversation

@gagan-bhullar-tech
Copy link
Contributor

closes: #41580

This PR fixes log out link in no roles and permissions error page


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Aug 28, 2024
@gagan-bhullar-tech
Copy link
Contributor Author

@shahar1 can you please review

Copy link

@rohitnandi12 rohitnandi12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing Paragraph closing tag

@shahar1
Copy link
Contributor

shahar1 commented Aug 28, 2024

Excellent! Thank you.

@shahar1 shahar1 merged commit 032ac87 into apache:main Aug 28, 2024
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 28, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@shahar1 shahar1 added this to the Airflow 2.10.1 milestone Aug 28, 2024
shahar1 pushed a commit to shahar1/airflow that referenced this pull request Aug 28, 2024
* logout link in no roles error page fix

* review comments

(cherry picked from commit 032ac87)
shahar1 added a commit that referenced this pull request Aug 29, 2024
* logout link in no roles error page fix

* review comments

(cherry picked from commit 032ac87)

Co-authored-by: Gagan Bhullar <g.deepsingh1@gmail.com>
@utkarsharma2 utkarsharma2 added the type:bug-fix Changelog: Bug Fixes label Aug 30, 2024
utkarsharma2 pushed a commit that referenced this pull request Sep 2, 2024
* logout link in no roles error page fix

* review comments

(cherry picked from commit 032ac87)

Co-authored-by: Gagan Bhullar <g.deepsingh1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logout link in no roles and permissions error page is broken

4 participants