Skip to content

Adding tojson filter to example_inlet_event_extra example dag #41873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
potiuk merged 2 commits into from
Aug 30, 2024
Merged

Adding tojson filter to example_inlet_event_extra example dag #41873

potiuk merged 2 commits into from
Aug 30, 2024

Conversation

@amoghrajesh
Copy link
Contributor

@amoghrajesh amoghrajesh commented Aug 30, 2024 •
edited
Loading

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@uranusjr
Copy link
Member

uranusjr commented Aug 30, 2024

Why? I feel it’s not a bad idea to show how this can be used in a Jinja template.

@amoghrajesh amoghrajesh changed the title Converting BashOperator to PythonOperator for dataset example_dag Adding tojson filter to example_inlet_event_extra example dag Aug 30, 2024
@amoghrajesh
Copy link
Contributor Author

amoghrajesh commented Aug 30, 2024

Why? I feel it’s not a bad idea to show how this can be used in a Jinja template.

Updated the PR based on our discussion offline

@shahar1 shahar1 added this to the Airflow 2.10.1 milestone Aug 30, 2024
@shahar1
Copy link
Contributor

shahar1 commented Aug 30, 2024 •
edited
Loading

Why? I feel it’s not a bad idea to show how this can be used in a Jinja template.

Updated the PR based on our discussion offline

Could you please backport to v2-10-test?

@potiuk potiuk merged commit 87a4a51 into apache:main Aug 30, 2024
potiuk pushed a commit to potiuk/airflow that referenced this pull request Aug 30, 2024
@amoghrajesh @potiuk
Adding tojson filter to example_inlet_event_extra example dag (apache…
8f665be 
…#41873)

(cherry picked from commit 87a4a51)
@potiuk potiuk mentioned this pull request Aug 30, 2024
Merged
potiuk added a commit that referenced this pull request Aug 30, 2024
@potiuk @amoghrajesh
Adding tojson filter to example_inlet_event_extra example dag (#41873) (
e43d8fa 
#41890)

(cherry picked from commit 87a4a51)

Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
@utkarsharma2 utkarsharma2 added the type:bug-fix Changelog: Bug Fixes label Aug 30, 2024
utkarsharma2 pushed a commit that referenced this pull request Sep 2, 2024
@potiuk @amoghrajesh @utkarsharma2
Adding tojson filter to example_inlet_event_extra example dag (#41873) (
09ec261 
#41890)

(cherry picked from commit 87a4a51)

Co-authored-by: Amogh Desai <amoghrajesh1999@gmail.com>
@potiuk potiuk mentioned this pull request Sep 3, 2024
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk approved these changes

@uranusjr uranusjr uranusjr approved these changes

@romsharon98 romsharon98 romsharon98 approved these changes

@shahar1 shahar1 shahar1 approved these changes

@jedcunningham jedcunningham Awaiting requested review from jedcunningham

Assignees

No one assigned

Labels

type:bug-fix Changelog: Bug Fixes

Projects

None yet

Milestone

Airflow 2.10.1

Development

Successfully merging this pull request may close these issues.

6 participants

@amoghrajesh @uranusjr @shahar1 @potiuk @romsharon98 @utkarsharma2