AIP-69: Add CLI to Edge Provider #42050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
requested review from
ashb,
jedcunningham and
potiuk
as code owners
jscheffl
force-pushed
the
feature/aip-69-remote-executor-provider-cli
branch
3 times, most recently
from
fb29d4e to
9bb1f4c
Compare
jscheffl
force-pushed
the
feature/aip-69-remote-executor-provider-cli
branch
from
9bb1f4c to
1ef51d0
Compare
shahar1
approved these changes
Sep 24, 2024
Contributor
shahar1
left a comment
shahar1
left a comment
There was a problem hiding this comment.
Looks great!
Small comments, nits and proofreading :)
jscheffl
force-pushed
the
feature/aip-69-remote-executor-provider-cli
branch
from
1ef51d0 to
f2a3593
Compare
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
* Add CLI to Edge Provider * Review feedback
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
* Add CLI to Edge Provider * Review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a split of #41729 and builds on-top of #42046 and #42047 to make review easier.
It only contains the new Edge CLI functions needed of the edge provider package - the CLI is needed to run the worker on the remote site. The first commit is from the other base PRs and if this is merged will go-away on rebase. If you want to see Executor implementation only, please take a look to the second commit only,