apply otel_service on metrics #42242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Member
hussein-awala
left a comment
hussein-awala
left a comment
There was a problem hiding this comment.
Failure in the non-db tests
Contributor
Author
Running this test in main, and it failed with the same error:
Maybe @ferruzzi can help us figure it out? |
Contributor
Author
|
This PR: #42267 should fix the current failed tests |
romsharon98
force-pushed
the
fix/otel-service-name
branch
from
40274be to
aa9d187
Compare
Contributor
Yeah, looks like you got it sorted out. Looks like it was a side-effect of the PR which converted reporting timers from seconds to millis, |
eladkal
reviewed
Sep 20, 2024
romsharon98
added
type:bug-fix
ferruzzi
approved these changes
Sep 23, 2024
romsharon98
added a commit
to romsharon98/airflow
that referenced
this pull request
Sep 24, 2024
* apply otel_service on metrics * change version_added to 2.10.3 (cherry picked from commit e14b4ca)
romsharon98
added a commit
that referenced
this pull request
Sep 25, 2024
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
* apply otel_service on metrics * change version_added to 2.10.3
utkarsharma2
pushed a commit
that referenced
this pull request
Oct 23, 2024
utkarsharma2
pushed a commit
that referenced
this pull request
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #42210
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.