-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Support for Kubernetes Executor side task attempt logging for failed tasks in case of task pods doesn't reach running state #42412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jedcunningham / @hussein-awala |
407476a to
140166f
Compare
|
@romsharon98 |
|
@jedcunningham / @hussein-awala |
|
@dstandish |
Yes, you add a log record. Was done recently in an aws executor |
Ok following up with more specifics this morning. Look at executors do not have access to a session, so from executor when we need to send this kind of message, we write the log records to a queue, and the scheduler consumes this queue and writes to db. cc @potiuk |
Nice. |
|
@dirrao what is the status of this PR? |
I’ve implemented the changes on the Kubernetes executor to align with the new base executor feature. However, I’m uncertain about how to adapt these updates in the Kubernetes watcher code. |
|
@dirrao why do you need to push anything to the watcher here? |
|
TaskContextLogger is removed from airflow; this PR needs to be updated to use the log table. The feature was added in this pr #40867 and you can see an example of its usage there. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
Right now, when the tasks fail due to pod launch failures or the pod is stuck in the pending phase, then the task logs from the UI are empty. It is very inconvenient for airflow consumers to debug it. They might not have access to the scheduler logs. We can push these failure reasons from the Kubernetes executor to task logs. So, that airflow consumers can able to see task failure reasons from the UI.
closes: #37435