Flush less in dataset manager #42458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't really *need* those objects in the database after the manager (simply in the memory-managed SQLAlchemy session is good enough), and since the objects are still transaction-held, they can't be accessed by the listener hooks even if they are in the database anyway. I also took the oppertunity to turn all listener method to class methods instead. This doesn't really make any difference (the manager does not hold instance-level values), and we need at least some of the methods to be class-level (for the internal API), and it's more consistent to have them all be class-level.
uranusjr
requested review from
ephraimbuddy and
pierrejeambrun
as code owners
uranusjr
force-pushed
the
refactor-register-dataset-change
branch
from
fdb6ade to
ee1e157
Compare
jedcunningham
approved these changes
Sep 25, 2024
Some flushes still needed for tests. The dataset object cache should still flush, but only exactly one is needed for all missing datasets, instead of one for each.
uranusjr
force-pushed
the
refactor-register-dataset-change
branch
from
ee1e157 to
f3f70fd
Compare
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #42343 (comment)
We don't really need those objects in the database after the manager (simply in the memory-managed SQLAlchemy session is good enough), and since the objects are still transaction-held, they can't be accessed by the listener hooks even if they are in the database anyway.
I also took the oppertunity to turn all listener method to class methods instead. This doesn't really make any difference (the manager does not hold instance-level values), and we need at least some of the methods to be class-level (for the internal API), and it's more consistent to have them all be class-level.