Added task_instance_mutation_hook for mapped operator index 0 #42661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
reviewed
Oct 7, 2024
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Thanks for the improvement. Besides the comment - can you please also add a unit test for the feature to ensure a regression is prevented if code is re-worked?
jscheffl
approved these changes
Oct 16, 2024
jscheffl
approved these changes
Oct 16, 2024
R7L208
pushed a commit
to R7L208/airflow
that referenced
this pull request
Oct 17, 2024
…#42661) * Added task_instance_mutation_hook for mapped operator index 0 * Added unit test --------- Co-authored-by: Marco Küttelwesch <marco.kuettelwesch@de.bosch.com>
harjeevanmaan
pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
…#42661) * Added task_instance_mutation_hook for mapped operator index 0 * Added unit test --------- Co-authored-by: Marco Küttelwesch <marco.kuettelwesch@de.bosch.com>
PaulKobow7536
pushed a commit
to PaulKobow7536/airflow
that referenced
this pull request
Oct 24, 2024
…#42661) * Added task_instance_mutation_hook for mapped operator index 0 * Added unit test --------- Co-authored-by: Marco Küttelwesch <marco.kuettelwesch@de.bosch.com>
This was referenced Oct 28, 2024
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
…#42661) * Added task_instance_mutation_hook for mapped operator index 0 * Added unit test --------- Co-authored-by: Marco Küttelwesch <marco.kuettelwesch@de.bosch.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During working with the task instance mutation hook feature I found an Issue with the execution of the hook and the mapped operator. The Hook was only executed for the expanded tasks index > 0 and the Index 0 was not executed with the hook.
This PR adds call of task_instance_mutation_hook if the index 0 does not exists in the DB.