Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Oct 3, 2024

Pydantic 2.6.4 fixes problem with AliasGenerator to throw error when generating schema - see an issue in Pydantic repository pydantic/pydantic#8768


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Pydantic 2.6.4 fixes problem with AliasGenerator to throw error when
generating schema - see an issue in Pydantic repository
pydantic/pydantic#8768
@potiuk
Copy link
Member Author

potiuk commented Oct 3, 2024

cc: @omkar-foss

@potiuk
Copy link
Member Author

potiuk commented Oct 3, 2024

See #42370 (comment) for more context.

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks Jarek :)

Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@pierrejeambrun
Copy link
Member

Restarted the failed Job, 🤞

@pierrejeambrun
Copy link
Member

Green 🎉

@pierrejeambrun pierrejeambrun merged commit 741276c into apache:main Oct 3, 2024
@omkar-foss
Copy link
Collaborator

Great! Now that Pydantic min version is updated, I'll reintroduceAliasGenerator in the next PR (for this issue: #42652).

@potiuk
Copy link
Member Author

potiuk commented Oct 3, 2024

Great! Now that Pydantic min version is updated, I'll reintroduceAliasGenerator in the next PR (for this issue: #42652).

Cool

joaopamaral pushed a commit to joaopamaral/airflow that referenced this pull request Oct 21, 2024
Pydantic 2.6.4 fixes problem with AliasGenerator to throw error when
generating schema - see an issue in Pydantic repository
pydantic/pydantic#8768
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
Pydantic 2.6.4 fixes problem with AliasGenerator to throw error when
generating schema - see an issue in Pydantic repository
pydantic/pydantic#8768
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants