Skip to content

Conversation

@bugraoz93
Copy link
Contributor

@bugraoz93 bugraoz93 commented Oct 4, 2024

Fix main failures and adjust test names and file names according to changes in dataset -> asset.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@bugraoz93 bugraoz93 changed the title Fix main Test Faluires Fix main Test Failures Oct 4, 2024
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds promising... but the tests would fail in Airflow 2.10 then?

@bugraoz93 bugraoz93 changed the title Fix main Test Failures Fix main Branch Test Failures Oct 4, 2024
@bugraoz93
Copy link
Contributor Author

Doesn't it depend on whether these changes have already been backported? #42579

@bugraoz93
Copy link
Contributor Author

bugraoz93 commented Oct 4, 2024

I have seen it neither in v2-10-test nor 2.10.2. So I assume it should be good if I am not missing somethings 🙂

@jscheffl
Copy link
Contributor

jscheffl commented Oct 4, 2024

I have seen it neither in v2-10-test nor 2.10.2. So I assume it should be good if I am not missing somethings 🙂

The renaming Dataset->Asset is a breaking change that is only for Airflow 3 line. All providers (and I assume also pytests of providers) need to be compatible with Airflow 2 and 3 line.

@uranusjr @Lee-W Do you have any idea/guidance? If FAB needs to support "both worlds" would pytests then need to have a "skipif" and carry both back-end implementations?

@vincbeck
Copy link
Contributor

vincbeck commented Oct 4, 2024

These tests are already skipped if Airflow < 3

@vincbeck vincbeck merged commit c157503 into apache:main Oct 4, 2024
@Lee-W
Copy link
Member

Lee-W commented Oct 6, 2024

Thanks @bugraoz93 ! Missed this one 🤦‍♂️

@jscheffl I think we already have the compat code in FAB. the permission side should be fine, but asset endpoints won't exist in <3.0 so they should be skipped for <3.0

joaopamaral pushed a commit to joaopamaral/airflow that referenced this pull request Oct 21, 2024
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants