-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Fix main Branch Test Failures #42744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds promising... but the tests would fail in Airflow 2.10 then?
|
Doesn't it depend on whether these changes have already been backported? #42579 |
|
I have seen it neither in |
The renaming Dataset->Asset is a breaking change that is only for Airflow 3 line. All providers (and I assume also pytests of providers) need to be compatible with Airflow 2 and 3 line. @uranusjr @Lee-W Do you have any idea/guidance? If FAB needs to support "both worlds" would pytests then need to have a "skipif" and carry both back-end implementations? |
|
These tests are already skipped if Airflow < 3 |
|
Thanks @bugraoz93 ! Missed this one 🤦♂️ @jscheffl I think we already have the compat code in FAB. the permission side should be fine, but asset endpoints won't exist in <3.0 so they should be skipped for <3.0 |
Fix main failures and adjust test names and file names according to changes in dataset -> asset.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.