Follow-up SLA purge #42808
Merged
Follow-up SLA purge #42808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferruzzi
requested review from
XD-DENG,
ashb,
bbovenzi,
ephraimbuddy,
jscheffl,
kaxil,
pierrejeambrun and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:API
Closed
dstandish
reviewed
Oct 8, 2024
dstandish
reviewed
Oct 8, 2024
ferruzzi
commented
Oct 9, 2024
Co-Authored-By: dstandish <dstandish@users.noreply.github.com>
# Conflicts: # tests/api_connexion/endpoints/test_mapped_task_instance_endpoint.py # tests/api_connexion/endpoints/test_task_instance_endpoint.py # tests/providers/fab/auth_manager/api_endpoints/test_task_instance_endpoint.py # tests/providers/smtp/notifications/test_smtp.py # tests/test_utils/db.py
dstandish
approved these changes
Oct 10, 2024
o-nikolas
approved these changes
Oct 10, 2024
Contributor
Author
|
I'm guessing I did something wrong with the merge conflicts, I'll try to get it sorted today |
Contributor
Author
|
The remaining failing lowest direct dependency test is unrelated from the MS package and @gopidesupavan is working on the fix for that. |
Member
this is fixed now.. you may rebase :) |
Contributor
Author
|
Finally all green. |
Contributor
yee haw! |
Contributor
|
let er rip |
Member
|
Cool 🚀 |
R7L208
pushed a commit
to R7L208/airflow
that referenced
this pull request
Oct 17, 2024
Co-authored-by: dstandish <dstandish@users.noreply.github.com>
harjeevanmaan
pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
Co-authored-by: dstandish <dstandish@users.noreply.github.com>
PaulKobow7536
pushed a commit
to PaulKobow7536/airflow
that referenced
this pull request
Oct 24, 2024
Co-authored-by: dstandish <dstandish@users.noreply.github.com>
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
Co-authored-by: dstandish <dstandish@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #42285
@dstandish pointed out that I missed the SlaMiss model and supporting code. This should take care of it
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.