Skip to content

Conversation

@vincbeck
Copy link
Contributor

@vincbeck vincbeck commented Oct 9, 2024

See discussion


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@vincbeck vincbeck force-pushed the vincbeck/simple_am_generated_file branch from ac57857 to c9ee0df Compare October 9, 2024 16:54
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me.

Would be "cool" if not created that upon start via Breeze the default admin/admin is created by Breeze so that after clean checkout it runs out-of-the-box... but not required in this PR...

@vincbeck
Copy link
Contributor Author

vincbeck commented Oct 9, 2024

Looks good for me.

Would be "cool" if not created that upon start via Breeze the default admin/admin is created by Breeze so that after clean checkout it runs out-of-the-box... but not required in this PR...

A user is created if no user is defined and generate the password for you. The file where the password is saved is now in /files so that the password does not change every-time you restart your env. You can also modify the password directly in this file and set it to admin if you want

@vincbeck vincbeck force-pushed the vincbeck/simple_am_generated_file branch from c9ee0df to a2b704e Compare October 9, 2024 20:10
@potiuk
Copy link
Member

potiuk commented Oct 9, 2024

Maybe we can have a non-specific env variable and define it in BREEZE instead?

say AIRFLOW_AUTH_MANAGER_CREDENTIAL_DIRECTORY ? Then we will just have to set it in entrypoint_ci.sh.

@kaxil
Copy link
Member

kaxil commented Oct 9, 2024

Maybe we can have a non-specific env variable and define it in BREEZE instead?

say AIRFLOW_AUTH_MANAGER_CREDENTIAL_DIRECTORY ? Then we will just have to set it in entrypoint_ci.sh.

Yeah, I like that

@vincbeck vincbeck force-pushed the vincbeck/simple_am_generated_file branch from a2b704e to 1ebf550 Compare October 10, 2024 17:00
@vincbeck vincbeck requested review from ashb and potiuk as code owners October 10, 2024 17:00
@vincbeck
Copy link
Contributor Author

I just did as you suggested :)

@vincbeck vincbeck force-pushed the vincbeck/simple_am_generated_file branch from 1ebf550 to 46a2ed9 Compare October 10, 2024 17:01
@vincbeck vincbeck force-pushed the vincbeck/simple_am_generated_file branch from 46a2ed9 to ad90090 Compare October 10, 2024 19:56
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

vincbeck and others added 2 commits October 10, 2024 16:13
@potiuk potiuk merged commit d6a1a52 into apache:main Oct 13, 2024
pavansharma36 pushed a commit to pavansharma36/airflow that referenced this pull request Oct 14, 2024
…ords (apache#42860)

* Change directory used by simple auth manager to store generated passwords

* Update airflow/auth/managers/simple/simple_auth_manager.py

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>

---------

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
@vincbeck vincbeck deleted the vincbeck/simple_am_generated_file branch October 17, 2024 14:55
R7L208 pushed a commit to R7L208/airflow that referenced this pull request Oct 17, 2024
…ords (apache#42860)

* Change directory used by simple auth manager to store generated passwords

* Update airflow/auth/managers/simple/simple_auth_manager.py

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>

---------

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
harjeevanmaan pushed a commit to harjeevanmaan/airflow that referenced this pull request Oct 23, 2024
…ords (apache#42860)

* Change directory used by simple auth manager to store generated passwords

* Update airflow/auth/managers/simple/simple_auth_manager.py

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>

---------

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
PaulKobow7536 pushed a commit to PaulKobow7536/airflow that referenced this pull request Oct 24, 2024
…ords (apache#42860)

* Change directory used by simple auth manager to store generated passwords

* Update airflow/auth/managers/simple/simple_auth_manager.py

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>

---------

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
…ords (apache#42860)

* Change directory used by simple auth manager to store generated passwords

* Update airflow/auth/managers/simple/simple_auth_manager.py

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>

---------

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants