Make conn id parameters templated in GenericTransfer and also allow passing hook parameters like in BaseSQLOperator #42891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…conn_id's for GenericTransfer and also allow passing hook params for each connection in GenericTransfer
…GenericTransfer and BaseSQLOperator
…r as it's part of Airflow itself
…n GenericTransfer as it's part of Airflow itself
Member
|
Looks like there is some problem with minimum version of one of microsoft dependencies. Bringing it down, brings opentelemetry dependency down and this seems to break imports. Unfold the failng test output for microsoft.azure and you will see it: |
Contributor
Author
Seems to be fine now after I updated the branch |
potiuk
reviewed
Oct 14, 2024
potiuk
reviewed
Oct 14, 2024
Member
|
There are some compatibility Airflow 3 / Airflow 2 issues that need to be addressed :) |
…viders-common-sql version 1.18.0 or higher
Contributor
Author
All issues fixed |
83 tasks
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
…assing hook parameters like in BaseSQLOperator (apache#42891) * refactored: Added hook_params to get_hook BaseHook method, templated conn_id's for GenericTransfer and also allow passing hook params for each connection in GenericTransfer --------- Co-authored-by: David Blain <david.blain@infrabel.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today I've discovered that the conn id parameters (source_conn_id and destination_conn_id) aren't templated in the GenericTransfer. This PR will also allow passing hook parameters like in BaseSQLOperator. Refactored the get_hook method in BaseOperator so that in the future it can be used in a generic way, added tests to remove backward compatibility code for Airflow 2.8.x once min version of provider is Aiflow 3.0.0 or higher.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.