Add retry on error 502 and 504 #42994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 14, 2024 09:27
majorosdonat
changed the title
jscheffl
reviewed
Oct 14, 2024
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
CI fails - otherwise some minor comments. Otherwise looking good.
jscheffl
approved these changes
Oct 15, 2024
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Thanks for the contribution and the re-work. Looks good for me as well as the tests added.
I'd classify this as a bug and propose to back-port this also to v2-line
jscheffl
pushed a commit
to boschglobal/airflow
that referenced
this pull request
Oct 15, 2024
* Add retry on error 502 and 504 * fix mypy findings * Add pytest * Convert response code to HTTPStatus * Add docs to retriable exception * extend docs for AirflowHttpException * Fix syntax and typos * fix pytest * fix static checks * fix some static checks * Fix ruff * fix pre-commit --------- Co-authored-by: Majoros Donat (XC-DX/EET2-Bp) <donat.majoros2@hu.bosch.com> (cherry picked from commit 477d747)
jscheffl
added a commit
that referenced
this pull request
Oct 15, 2024
* Add retry on error 502 and 504 * fix mypy findings * Add pytest * Convert response code to HTTPStatus * Add docs to retriable exception * extend docs for AirflowHttpException * Fix syntax and typos * fix pytest * fix static checks * fix some static checks * Fix ruff * fix pre-commit --------- Co-authored-by: Majoros Donat (XC-DX/EET2-Bp) <donat.majoros2@hu.bosch.com> (cherry picked from commit 477d747) Co-authored-by: majorosdonat <mjd2bp@bosch.com>
R7L208
pushed a commit
to R7L208/airflow
that referenced
this pull request
Oct 17, 2024
* Add retry on error 502 and 504 * fix mypy findings * Add pytest * Convert response code to HTTPStatus * Add docs to retriable exception * extend docs for AirflowHttpException * Fix syntax and typos * fix pytest * fix static checks * fix some static checks * Fix ruff * fix pre-commit --------- Co-authored-by: Majoros Donat (XC-DX/EET2-Bp) <donat.majoros2@hu.bosch.com>
utkarsharma2
pushed a commit
that referenced
this pull request
Oct 23, 2024
* Add retry on error 502 and 504 * fix mypy findings * Add pytest * Convert response code to HTTPStatus * Add docs to retriable exception * extend docs for AirflowHttpException * Fix syntax and typos * fix pytest * fix static checks * fix some static checks * Fix ruff * fix pre-commit --------- Co-authored-by: Majoros Donat (XC-DX/EET2-Bp) <donat.majoros2@hu.bosch.com> (cherry picked from commit 477d747) Co-authored-by: majorosdonat <mjd2bp@bosch.com>
harjeevanmaan
pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
* Add retry on error 502 and 504 * fix mypy findings * Add pytest * Convert response code to HTTPStatus * Add docs to retriable exception * extend docs for AirflowHttpException * Fix syntax and typos * fix pytest * fix static checks * fix some static checks * Fix ruff * fix pre-commit --------- Co-authored-by: Majoros Donat (XC-DX/EET2-Bp) <donat.majoros2@hu.bosch.com>
PaulKobow7536
pushed a commit
to PaulKobow7536/airflow
that referenced
this pull request
Oct 24, 2024
* Add retry on error 502 and 504 * fix mypy findings * Add pytest * Convert response code to HTTPStatus * Add docs to retriable exception * extend docs for AirflowHttpException * Fix syntax and typos * fix pytest * fix static checks * fix some static checks * Fix ruff * fix pre-commit --------- Co-authored-by: Majoros Donat (XC-DX/EET2-Bp) <donat.majoros2@hu.bosch.com>
utkarsharma2
pushed a commit
that referenced
this pull request
Oct 24, 2024
* Add retry on error 502 and 504 * fix mypy findings * Add pytest * Convert response code to HTTPStatus * Add docs to retriable exception * extend docs for AirflowHttpException * Fix syntax and typos * fix pytest * fix static checks * fix some static checks * Fix ruff * fix pre-commit --------- Co-authored-by: Majoros Donat (XC-DX/EET2-Bp) <donat.majoros2@hu.bosch.com> (cherry picked from commit 477d747) Co-authored-by: majorosdonat <mjd2bp@bosch.com>
This was referenced Oct 28, 2024
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
* Add retry on error 502 and 504 * fix mypy findings * Add pytest * Convert response code to HTTPStatus * Add docs to retriable exception * extend docs for AirflowHttpException * Fix syntax and typos * fix pytest * fix static checks * fix some static checks * Fix ruff * fix pre-commit --------- Co-authored-by: Majoros Donat (XC-DX/EET2-Bp) <donat.majoros2@hu.bosch.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an application gateway or a Kubernetes ingress cannot find a running instance of a webserver hosting the API
The edge worker crashes and restarts due to HTTP error 502 and 504 (during webserver startup). To prevent this, the retried errors are extended with "bad gateway" and "gateway timeout" in the internal api call.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.