Rename views to routes for FastAPI apps #43057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincbeck
approved these changes
Oct 15, 2024
Contributor
vincbeck
left a comment
vincbeck
left a comment
There was a problem hiding this comment.
Makes more sense indeed
kaxil
force-pushed
the
rename-views-routes
branch
from
46e4073 to
7228168
Compare
This is part of the change I want to do for apache#43015 but going to break it down to keep it manageable.
kaxil
force-pushed
the
rename-views-routes
branch
from
7228168 to
b37467f
Compare
R7L208
pushed a commit
to R7L208/airflow
that referenced
this pull request
Oct 17, 2024
This is part of the change I want to do for apache#43015 but going to break it down to keep it manageable. Since these are actual routes for APIs, renaming them to routes instead of views.
harjeevanmaan
pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
This is part of the change I want to do for apache#43015 but going to break it down to keep it manageable. Since these are actual routes for APIs, renaming them to routes instead of views.
PaulKobow7536
pushed a commit
to PaulKobow7536/airflow
that referenced
this pull request
Oct 24, 2024
This is part of the change I want to do for apache#43015 but going to break it down to keep it manageable. Since these are actual routes for APIs, renaming them to routes instead of views.
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
This is part of the change I want to do for apache#43015 but going to break it down to keep it manageable. Since these are actual routes for APIs, renaming them to routes instead of views.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the change I want to do for #43015 but going to break it down to keep it manageable.
Since these are actual routes for APIs, renaming them to routes instead of views.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.