Skip to content

Conversation

@dimberman
Copy link
Contributor

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

Description

  • Here are some details about my PR, including screenshots of any UI changes:

As kubernetes is moving away from docker to OCI, it will be more correct to use the 'dags_in_image' name to be more container system agnostic

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

Code Quality

  • Passes flake8

As kubernetes is moving away from docker to OCI, it will be more correct to use the
'dags_in_image' name to be more container system agnostic
@feng-tao feng-tao merged commit 457ad83 into apache:master Dec 13, 2018
@feng-tao
Copy link
Member

lgtm

feng-tao pushed a commit to feng-tao/airflow that referenced this pull request Dec 13, 2018
feng-tao pushed a commit that referenced this pull request Dec 13, 2018
* Revert "[AIRFLOW-3505] replace 'dags_in_docker' with 'dags_in_image' (#4311)"

This reverts commit 457ad83.

* Revert "[AIRFLOW-2770] kubernetes: add support for dag folder in the docker image (#3683)"

This reverts commit e9a09d4.
aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request Jan 3, 2019
…4311)

As kubernetes is moving away from docker to OCI, it will be more correct to use the
'dags_in_image' name to be more container system agnostic
aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request Jan 3, 2019
* Revert "[AIRFLOW-3505] replace 'dags_in_docker' with 'dags_in_image' (apache#4311)"

This reverts commit 457ad83.

* Revert "[AIRFLOW-2770] kubernetes: add support for dag folder in the docker image (apache#3683)"

This reverts commit e9a09d4.
wmorris75 pushed a commit to modmed-external/incubator-airflow that referenced this pull request Jul 29, 2019
…4311)

As kubernetes is moving away from docker to OCI, it will be more correct to use the
'dags_in_image' name to be more container system agnostic
wmorris75 pushed a commit to modmed-external/incubator-airflow that referenced this pull request Jul 29, 2019
* Revert "[AIRFLOW-3505] replace 'dags_in_docker' with 'dags_in_image' (apache#4311)"

This reverts commit 457ad83.

* Revert "[AIRFLOW-2770] kubernetes: add support for dag folder in the docker image (apache#3683)"

This reverts commit e9a09d4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants