add ProcessingEngineRunFacet to OL DAG Start event #43213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romsharon98
approved these changes
Oct 21, 2024
Contributor
romsharon98
left a comment
romsharon98
left a comment
There was a problem hiding this comment.
Changes looks good.
Can you add unit tests for get_processing_engine_facet?
mobuchowski
force-pushed
the
processing-facet-dag-event
branch
from
8a2f077 to
3129da8
Compare
Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
mobuchowski
force-pushed
the
processing-facet-dag-event
branch
from
3129da8 to
e57a5ee
Compare
Contributor
Author
|
Added those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ProcessingEngineRunFacet to OL DAG Start event. The facet was already added to Task-level events, added this to have Airflow version information straight on DAG start.