More correctly work around uv sync issue with python 3.10+ only dep
#43227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just having the python_version requirement doesn't seem to correctly make uv "fork" the resolver path (Charlie's words/terms), so we either need to specify both module versions here. The other option that could work is putting this in our pyproject.toml ``` [tool.uv] environments = ["python_version >= '3.10'", "python_version < '3.10'"] ``` But having both versions specified keeps the fix localized into the provider so I have chosen this approach
ashb
commented
Oct 21, 2024
potiuk
approved these changes
Oct 21, 2024
kaxil
approved these changes
Oct 21, 2024
harjeevanmaan
pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
…apache#43227) Just having the python_version requirement doesn't seem to correctly make uv "fork" the resolver path (Charlie's words/terms), so we either need to specify both module versions here. The other option that could work is putting this in our pyproject.toml ``` [tool.uv] environments = ["python_version >= '3.10'", "python_version < '3.10'"] ``` But having both versions specified keeps the fix localized into the provider so I have chosen this approach. This is likely why the exclued-python-version setting we already had wasn't working for uv sync. astral-sh/uv#4668
PaulKobow7536
pushed a commit
to PaulKobow7536/airflow
that referenced
this pull request
Oct 24, 2024
…apache#43227) Just having the python_version requirement doesn't seem to correctly make uv "fork" the resolver path (Charlie's words/terms), so we either need to specify both module versions here. The other option that could work is putting this in our pyproject.toml ``` [tool.uv] environments = ["python_version >= '3.10'", "python_version < '3.10'"] ``` But having both versions specified keeps the fix localized into the provider so I have chosen this approach. This is likely why the exclued-python-version setting we already had wasn't working for uv sync. astral-sh/uv#4668
83 tasks
Contributor
|
@ashb -- This should be fixed in the next uv release, I just tested it. |
Contributor
|
See: astral-sh/uv#8628 |
Merged
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
…apache#43227) Just having the python_version requirement doesn't seem to correctly make uv "fork" the resolver path (Charlie's words/terms), so we either need to specify both module versions here. The other option that could work is putting this in our pyproject.toml ``` [tool.uv] environments = ["python_version >= '3.10'", "python_version < '3.10'"] ``` But having both versions specified keeps the fix localized into the provider so I have chosen this approach. This is likely why the exclued-python-version setting we already had wasn't working for uv sync. astral-sh/uv#4668
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just having the python_version requirement doesn't seem to correctly make uv
"fork" the resolver path (Charlie's words/terms), so we either need to specify
both module versions here. The other option that could work is putting this in
our pyproject.toml
But having both versions specified keeps the fix localized into the provider
so I have chosen this approach.
This is likely why the
exclued-python-versionsetting we already had wasn't working foruv sync.