Skip to content

Conversation

@kaxil
Copy link
Member

@kaxil kaxil commented Oct 23, 2024

https://pypi.org/project/uv/0.4.26/


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:dev-tools area:production-image Production image improvements and fixes labels Oct 23, 2024
@kaxil kaxil changed the title Bump uv to 0.4.24 Bump uv to 0.4.26 Oct 23, 2024
@potiuk
Copy link
Member

potiuk commented Oct 23, 2024

Strange but prod image verification failed - could be because of some uv problem. I re-run it.

@kaxil
Copy link
Member Author

kaxil commented Oct 23, 2024

Strange but prod image verification failed - could be because of some uv problem. I re-run it.

Yeah:

=================================== FAILURES ===================================
  ___________ TestPythonPackages.test_required_providers_are_installed ___________
  [gw2] linux -- Python 3.9.20 /tmp/tmplx3z9mmg/.venv/bin/python
  
  self = <docker_tests.test_prod_image.TestPythonPackages object at 0x7f7ce56bbc70>
  default_docker_image = 'ghcr.io/apache/airflow/main/prod/python3.9:b4a37f531cf739f8850e9795bab1473ebef212fd'
  
      def test_required_providers_are_installed(self, default_docker_image):
          if os.environ.get("TEST_SLIM_IMAGE"):
              packages_to_install = set(SLIM_IMAGE_PROVIDERS)
              package_file = "hatch_build.py"
          else:
              packages_to_install = set(REGULAR_IMAGE_PROVIDERS)
              package_file = PROD_IMAGE_PROVIDERS_FILE_PATH
          assert len(packages_to_install) != 0
          output = run_bash_in_docker("airflow providers list --output json", image=default_docker_image)
  >       providers = json.loads(output)
  
  docker_tests/test_prod_image.py:94: 
  _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
  /opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/json/__init__.py:346: in loads
      return _default_decoder.decode(s)
  /opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/json/decoder.py:337: in decode
      obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
  
  self = <json.decoder.JSONDecoder object at 0x7f7ce715b6d0>
  s = '[2024-10-23T21:52:00.010+0000] {configuration.py:994} WARNING - section/key [core/asset_manager_kwargs] not found in ...kage_name": "apache-airflow-providers-standard", "description": "Airflow Standard Provider", "version": "1.0.0.dev0"}]'
  idx = 0
  
      def raw_decode(self, s, idx=0):
          """Decode a JSON document from ``s`` (a ``str`` beginning with
          a JSON document) and return a 2-tuple of the Python
          representation and the index in ``s`` where the document ended.
      
          This can be used to decode a JSON document from a string that may
          have extraneous data at the end.
      
          """
          try:
  >           obj, end = self.scan_once(s, idx)
  E           json.decoder.JSONDecodeError: Expecting ',' delimiter: line 1 column 6 (char 5)
  
  /opt/hostedtoolcache/Python/3.9.20/x64/lib/python3.9/json/decoder.py:353: JSONDecodeError
  =========================== short test summary info ============================
  FAILED docker_tests/test_prod_image.py::TestPythonPackages::test_required_providers_are_installed - json.decoder.JSONDecodeError: Expecting ',' delimiter: line 1 column 6 (char 5)

@kaxil
Copy link
Member Author

kaxil commented Oct 23, 2024

Strange but prod image verification failed - could be because of some uv problem. I re-run it.

Oh actually, looks like something is broken on main too: https://github.com/apache/airflow/actions/runs/11486815718/job/31971045626 (same error)

@kaxil
Copy link
Member Author

kaxil commented Oct 23, 2024

Strange but prod image verification failed - could be because of some uv problem. I re-run it.

Oh actually, looks like something is broken on main too: https://github.com/apache/airflow/actions/runs/11486815718/job/31971045626 (same error)

Ok, I know now. PR incoming

@potiuk
Copy link
Member

potiuk commented Oct 23, 2024

Ok, I know now. PR incoming

Yep:

WARNING - section/key [core/asset_manager_kwargs] not found in ...kage_name"

@kaxil
Copy link
Member Author

kaxil commented Oct 23, 2024

@potiuk Fix here: #43334

@kaxil
Copy link
Member Author

kaxil commented Oct 23, 2024

@potiuk Fix here: #43334

Proper fix at #43335

@kaxil
Copy link
Member Author

kaxil commented Oct 23, 2024

@potiuk Could I get a review on this :)

@kaxil kaxil merged commit df6050c into apache:main Oct 24, 2024
@kaxil kaxil deleted the bump-uv-0.4.26 branch October 24, 2024 00:13
PaulKobow7536 pushed a commit to PaulKobow7536/airflow that referenced this pull request Oct 24, 2024
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools area:production-image Production image improvements and fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants