Skip to content

Conversation

@shahar1
Copy link
Contributor

@shahar1 shahar1 commented Oct 24, 2024

TriggerRule.DUMMY has no effect in Airflow 3, so it could be safely removed.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@shahar1 shahar1 added this to the Airflow 2.10.3 milestone Oct 24, 2024
@shahar1 shahar1 force-pushed the remove-dummy-triggerrule branch 2 times, most recently from 9b6b686 to 64df531 Compare October 24, 2024 13:45
@shahar1 shahar1 added area:core kind:task A task that needs to be completed as part of a larger issue labels Oct 24, 2024
@shahar1 shahar1 modified the milestones: Airflow 2.10.3, Airflow 3.0.0 Oct 24, 2024
@shahar1 shahar1 force-pushed the remove-dummy-triggerrule branch from 64df531 to 2413c38 Compare October 24, 2024 14:09
@shahar1 shahar1 marked this pull request as draft October 24, 2024 14:10
@shahar1
Copy link
Contributor Author

shahar1 commented Oct 24, 2024

Unfortunately, TriggerRule.DUMMY is still operable in AIrflow 2, so I can't backport this one to v2-10-test. As I plan to make some compatible changes in the trigger rule depedencies - I want to avoid code deviations for now between the branches in this area.
For that reason, I'm drafting this PR for now.

@eladkal
Copy link
Contributor

eladkal commented Oct 24, 2024

Also needs news fragment as this is a breaking change

@shahar1 shahar1 added airflow3.0:candidate Potential candidates for Airflow 3.0 airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes labels Oct 24, 2024
@shahar1 shahar1 force-pushed the remove-dummy-triggerrule branch from 2413c38 to bb2b1e9 Compare October 26, 2024 09:16
@shahar1
Copy link
Contributor Author

shahar1 commented Oct 26, 2024

Unfortunately, TriggerRule.DUMMY is still operable in AIrflow 2, so I can't backport this one to v2-10-test. As I plan to make some compatible changes in the trigger rule depedencies - I want to avoid code deviations for now between the branches in this area. For that reason, I'm drafting this PR for now.

In a second thought, the compatible changes shouldn't affect the trigger_rule.py file (no expected changes in the other statuses), so it should be ok to merge.
I added a newsfragment (I had to obscure the content it due to check-for-inclusive-language 😅)

@shahar1 shahar1 marked this pull request as ready for review October 26, 2024 09:19
@shahar1 shahar1 requested review from eladkal and potiuk October 26, 2024 09:20
@shahar1 shahar1 force-pushed the remove-dummy-triggerrule branch from bb2b1e9 to 2ca19e4 Compare October 26, 2024 12:40
@shahar1 shahar1 force-pushed the remove-dummy-triggerrule branch from 2ca19e4 to 7bf2347 Compare November 7, 2024 18:32
@shahar1 shahar1 force-pushed the remove-dummy-triggerrule branch 2 times, most recently from 7bf2347 to 72f3399 Compare November 7, 2024 20:42
@shahar1 shahar1 force-pushed the remove-dummy-triggerrule branch from 72f3399 to b42f29c Compare November 8, 2024 06:46
@shahar1 shahar1 requested a review from eladkal November 8, 2024 06:47
@potiuk potiuk merged commit c82a76e into apache:main Nov 11, 2024
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
shahar1 added a commit to shahar1/airflow that referenced this pull request Dec 6, 2024
@shahar1 shahar1 mentioned this pull request Dec 6, 2024
shahar1 added a commit to shahar1/airflow that referenced this pull request Dec 6, 2024
shahar1 added a commit that referenced this pull request Dec 6, 2024
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes airflow3.0:candidate Potential candidates for Airflow 3.0 area:core kind:task A task that needs to be completed as part of a larger issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants