AIP-65: Update dag source endpoint to support versioning #43492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:API
ephraimbuddy
force-pushed
the
version-api
branch
2 times, most recently
from
bb2a352 to
3ec23a2
Compare
ephraimbuddy
force-pushed
the
version-api
branch
from
3ec23a2 to
c157489
Compare
ephraimbuddy
changed the title
ephraimbuddy
requested review from
XD-DENG,
ashb,
bbovenzi,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
ephraimbuddy
added
the
legacy api
ephraimbuddy
force-pushed
the
version-api
branch
from
c157489 to
8fce1aa
Compare
ephraimbuddy
commented
Nov 7, 2024
ephraimbuddy
force-pushed
the
version-api
branch
2 times, most recently
from
a541914 to
ef8cce6
Compare
1 task
ephraimbuddy
force-pushed
the
version-api
branch
2 times, most recently
from
611f8df to
9a2705b
Compare
ephraimbuddy
force-pushed
the
version-api
branch
from
9a2705b to
41107bc
Compare
Lee-W
reviewed
Nov 15, 2024
ephraimbuddy
force-pushed
the
version-api
branch
2 times, most recently
from
de6d1c0 to
32d6edc
Compare
jedcunningham
approved these changes
Nov 18, 2024
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Just one comment, otherwise looking good.
Lee-W
approved these changes
Nov 19, 2024
Enhanced the DAG source endpoint to support version-based retrieval Refactored the get_dag_source function to allow fetching specific versions of DAG source code using dag_id, version_name, and version_number parameters. Replaced file_token with dag_id in endpoint paths and removed unnecessary token-based access. Updated OpenAPI specifications and requested serializers to include new versioning parameters. Modified API response schema to include dag_id, version_name, and version_number for improved version tracking. Added/updated tests
ephraimbuddy
force-pushed
the
version-api
branch
from
32d6edc to
d55bb36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced the DAG source endpoint to support version-based retrieval
Refactored the get_dag_source function to allow fetching specific versions of DAG source code using dag_id, version_name, and version_number parameters.
Replaced file_token with dag_id in endpoint paths and removed unnecessary token-based access.
Updated OpenAPI specifications and requested serializers to include new versioning parameters.
Modified API response schema to include dag_id, and version_number for improved version tracking.
Added/updated tests