Skip to content

Conversation

@ambika-garg
Copy link
Contributor


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@ambika-garg
Copy link
Contributor Author

ambika-garg commented Oct 29, 2024

Hey @eladkal and @dabla, This pull request fixes the test case of powerbi_trigger, that initially took 30 seconds to execute. It is in continuation to PR #41331.

Screenshot 2024-10-29 at 3 47 20 PM

@potiuk
Copy link
Member

potiuk commented Oct 29, 2024

Looks like mypy does not like it :)

@jscheffl jscheffl merged commit b9513cc into apache:main Nov 9, 2024
@dabla
Copy link
Contributor

dabla commented Nov 9, 2024

Thank you @ambika-garg for the fix

@ambika-garg ambika-garg deleted the temp-3 branch November 10, 2024 22:20
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
* Optimize test that check trigger after being timeout

* Fix typing error

* Update test_powerbi.py

* refactor: Refactored powerbi_trigger fixture and used pytest.mark.parametrize to parametrize timeout

* Refactor: Remove parameterize marker

---------

Co-authored-by: David Blain <info@dabla.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants