Fix TrySelector for Mapped Tasks in Logs and Details Grid Panel #43565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
added
kind:bug
jscheffl
requested review from
ashb,
bbovenzi,
pierrejeambrun and
ryanahamilton
as code owners
jscheffl
added
type:bug-fix
bbovenzi
approved these changes
Nov 1, 2024
Contributor
bbovenzi
left a comment
bbovenzi
left a comment
There was a problem hiding this comment.
good catch. let's definitely backport this one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing try selector in UI for mapped tasks in Logs and Details panel. This bothered us in production really hard... was hoping somebody else was jumping on this and am wondering if nobody else is affected by this?
Took a moment to find the root cause, actually it was a simple thing: String replacement was not taken over for the effective call URL, such no history could be found, no history... no try selector buttons...
How to test: Run and retry a mapped task from the examples and see that the selector is showing up!
closes: #42357
Somewhat 2.10.3rc1 was cut.. hping some other issue is found that this find's its way to the next release, if too late for 2.10.3 then hopefully 2.10.4!
FYI @AutomationDev85 @clellmann @majorosdonat @OliverWannenwetsch