AIP-84 Get Task Instance Try Details #43675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:API
kandharvishnu
requested review from
bbovenzi,
ephraimbuddy,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
kandharvishnu
force-pushed
the
AIP-84_get_task_instance_try_details
branch
from
1167edf to
7a55eb9
Compare
rawwar
reviewed
Nov 6, 2024
tests/api_fastapi/core_api/routes/public/test_task_instances.py
Outdated
Show resolved
Hide resolved
kandharvishnu
force-pushed
the
AIP-84_get_task_instance_try_details
branch
2 times, most recently
from
d42bb1b to
bcd3c81
Compare
rawwar
reviewed
Nov 15, 2024
kandharvishnu
commented
Nov 15, 2024
rawwar
reviewed
Nov 15, 2024
1 task
rawwar
reviewed
Nov 15, 2024
Member
|
Need rebasing as well. |
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Overall looking good, a few suggestions, thanks
Member
|
Needs rebasing. We can merge after the small adjustments are done. |
kandharvishnu
requested review from
ashb,
eladkal,
hussein-awala,
jedcunningham,
mik-laj,
o-nikolas and
potiuk
as code owners
kandharvishnu
requested review from
XD-DENG,
bolkedebruin,
dstandish and
uranusjr
as code owners
kandharvishnu
force-pushed
the
AIP-84_get_task_instance_try_details
branch
from
7f7d8b4 to
8f534ab
Compare
kandharvishnu
force-pushed
the
AIP-84_get_task_instance_try_details
branch
from
8f534ab to
bde8478
Compare
pierrejeambrun
approved these changes
Nov 19, 2024
Contributor
|
Nice! On to the next one @kandharvishnu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to: #42370