[AIRFLOW-3576] Remove unnecessray arg 'root' for /delete in dag.html #4380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@Noremac201 may you advise on this PR as you authored the original commit (#3531)? Kindly let me know if I have misunderstood or missed anything in your implementation. Thanks! |
'root' is not used anywhere in `delete` method in either
www/views.py or www_rbac/views.py.
Having it in url_for("airflow.delete", dag_id=dag.dag_id, root=root)
in dag.html is meaningless.
XD-DENG
force-pushed
the
remove_unnecessary_arg_root
branch
from
3082886 to
1e87643
Compare
Member
Author
|
1 test (out of 9) failed due to transient error. |
Contributor
|
Lgtm👍 |
Member
|
have restarted the test |
Codecov Report
@@ Coverage Diff @@
## master #4380 +/- ##
==========================================
- Coverage 78.16% 78.16% -0.01%
==========================================
Files 204 204
Lines 16530 16530
==========================================
- Hits 12921 12920 -1
- Misses 3609 3610 +1
Continue to review full report at Codecov.
|
Member
Author
|
Hi @kaxil , a gentle ping. The tests have passed. |
Member
|
LGTM |
aliceabe
pushed a commit
to aliceabe/incubator-airflow
that referenced
this pull request
Jan 3, 2019
…pache#4380) 'root' is not used anywhere in `delete` method in either www/views.py or www_rbac/views.py. Having it in url_for("airflow.delete", dag_id=dag.dag_id, root=root) in dag.html is meaningless.
yohei1126
pushed a commit
to yohei1126/airflow
that referenced
this pull request
Jan 6, 2019
…pache#4380) 'root' is not used anywhere in `delete` method in either www/views.py or www_rbac/views.py. Having it in url_for("airflow.delete", dag_id=dag.dag_id, root=root) in dag.html is meaningless.
wmorris75
pushed a commit
to modmed-external/incubator-airflow
that referenced
this pull request
Jul 29, 2019
…pache#4380) 'root' is not used anywhere in `delete` method in either www/views.py or www_rbac/views.py. Having it in url_for("airflow.delete", dag_id=dag.dag_id, root=root) in dag.html is meaningless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
https://issues.apache.org/jira/browse/AIRFLOW-3576
Description
In
airflow/www/templates/airflow/dag.htmlorairflow/www_rbac/templates/airflow/dag.html, in line<a href="{{ url_for("airflow.delete", dag_id=dag.dag_id, root=root) }}",rootis not necessary, given it's not used anywhere in the'/delete'method in eitherairflow/www/views.pyorairflow/www_rbac/views.py.Please correct me if I'm incorrect about this or missed anything.