Skip to content

#43252 Disable extra links button if link is null or empty #43844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 2 commits into from
Nov 9, 2024
Merged

#43252 Disable extra links button if link is null or empty #43844

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90aa4c4
Disable button if link is null or empty
Nov 9, 2024
18953f4
Fix space
Nov 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airflow/www/static/js/dag/details/taskInstance/ExtraLinks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ const ExtraLinks = ({

const isSanitised = (url: string | null) => {
if (!url) {
return true;
return false; // Empty or null urls should cause the link to be disabled
}
const path = new URL(url, "http://localhost");
// Allow Absolute/Relative URL and prevent javascript:() from executing when passed as path.
Expand Down