Skip to content

Conversation

@rawwar
Copy link
Contributor

@rawwar rawwar commented Nov 11, 2024

related to #42701

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Nov 11, 2024
@rawwar rawwar force-pushed the kalyan/AIP-84/trigger_dag_run branch from b11977f to ed49619 Compare November 20, 2024 04:02
@rawwar rawwar added the legacy api Whether legacy API changes should be allowed in PR label Nov 22, 2024
@rawwar rawwar marked this pull request as ready for review November 22, 2024 17:31
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks looking good overall. A few suggestions.

@pierrejeambrun pierrejeambrun merged commit a1fbdb3 into apache:main Nov 27, 2024
ArshiaZr pushed a commit to ArshiaZr/airflow that referenced this pull request Nov 27, 2024
* init

* wip

* remove logical_date

* fix trigger dag_run

* tests WIP

* working tests

* remove logical_date from post body

* remove logical_date from tests

* fix

* include return type

* fix conf

* feedback

* fix tests

* Update tests/api_fastapi/core_api/routes/public/test_dag_run.py

* feedback
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
* init

* wip

* remove logical_date

* fix trigger dag_run

* tests WIP

* working tests

* remove logical_date from post body

* remove logical_date from tests

* fix

* include return type

* fix conf

* feedback

* fix tests

* Update tests/api_fastapi/core_api/routes/public/test_dag_run.py

* feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. legacy api Whether legacy API changes should be allowed in PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants