Refactor & rename metrics_consistency_on conf to timer_unit_consistency
#43966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
changed the title
metrics_consistency_on conf to `timer_unit_consis…metrics_consistency_on conf to timer_unit_consistency
kaxil
commented
Nov 13, 2024
kaxil
commented
Nov 13, 2024
ashb
approved these changes
Nov 13, 2024
…tency` Changes: - Replaces the `metrics_consistency_on` config with `timer_unit_consistency` for better clarity! - Improves the newsfragment entry & deprecation warning - Changes the default to be `False` so folks aren't caught by surprise. We should backport this to 2.11 and remove this setting from Airflow main
kaxil
force-pushed
the
refactor-metrics
branch
from
668c498 to
f07920b
Compare
Member
Author
|
The failed checks are unrelated and due to "docker timeouts" |
Contributor
|
I like the name change, but the default being "on" was discussed in the PR where it was added](#39908), why are we changing it now? This is a "breaking change" in that it requires adjusting StatsD dashboards, but it is being applied in 3.0 which is the time to do such changes, right? The last I heard in discussions was that StatsD was being moved to second-class and OTel Metrics were supposed to be treated as the standard starting in 3.0 Please read through the conversation on the other PR and reconsider this change. |
Member
Author
A few things:
|
Member
Author
|
The only thing different is instead of getting it in 3.0 with default "on" and breaking compact and removing it in 3.1 -- here we make it consistent that 3.0 will break it -- and we warn users in advance about this in 2.11 -- our bridge release. It will make it consistent with how we are breaking other things. |
Contributor
|
Thank you. |
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Nov 13, 2024
- Removes the `timer_unit_consistency` configuration option, standardizing all timer and timing metrics to milliseconds by default. - Updates metric loggers (e.g., Datadog, OpenTelemetry) to ensure uniform milliseconds-based reporting. - Cleans up related warnings! This is a follow-up of apache#43966 for main & Airflow 3
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Nov 13, 2024
- Removes the `timer_unit_consistency` configuration option, standardizing all timer and timing metrics to milliseconds by default. - Updates metric loggers (e.g., Datadog, OpenTelemetry) to ensure uniform milliseconds-based reporting. - Cleans up related warnings! This is a follow-up of apache#43966 for main & Airflow 3
amoghrajesh
pushed a commit
to astronomer/airflow
that referenced
this pull request
Nov 14, 2024
…tency` (apache#43966) Changes: - Replaces the `metrics_consistency_on` config with `timer_unit_consistency` for better clarity! - Improves the newsfragment entry & deprecation warning - Changes the default to be `False` so folks aren't caught by surprise. We should backport this to 2.11 and remove this setting from Airflow main
kaxil
added a commit
that referenced
this pull request
Nov 14, 2024
- Removes the `timer_unit_consistency` configuration option, standardizing all timer and timing metrics to milliseconds by default. - Updates metric loggers (e.g., Datadog, OpenTelemetry) to ensure uniform milliseconds-based reporting. - Cleans up related warnings! This is a follow-up of #43966 for main & Airflow 3
kaxil
added a commit
that referenced
this pull request
Apr 29, 2025
…tency` (#43966) Changes: - Replaces the `metrics_consistency_on` config with `timer_unit_consistency` for better clarity! - Improves the newsfragment entry & deprecation warning - Changes the default to be `False` so folks aren't caught by surprise. We should backport this to 2.11 and remove this setting from Airflow main (cherry picked from commit 1bd061d)
kaxil
added a commit
that referenced
this pull request
Apr 29, 2025
…tency` (#43966) Changes: - Replaces the `metrics_consistency_on` config with `timer_unit_consistency` for better clarity! - Improves the newsfragment entry & deprecation warning - Changes the default to be `False` so folks aren't caught by surprise. We should backport this to 2.11 and remove this setting from Airflow main (cherry picked from commit 1bd061d)
39 tasks
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
May 27, 2025
- Removes the `timer_unit_consistency` configuration option, standardizing all timer and timing metrics to milliseconds by default. - Updates metric loggers (e.g., Datadog, OpenTelemetry) to ensure uniform milliseconds-based reporting. - Cleans up related warnings! This is a follow-up of apache/airflow#43966 for main & Airflow 3 GitOrigin-RevId: 339bc7748156a4d099121092addb5af1da4e81e8
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 23, 2025
- Removes the `timer_unit_consistency` configuration option, standardizing all timer and timing metrics to milliseconds by default. - Updates metric loggers (e.g., Datadog, OpenTelemetry) to ensure uniform milliseconds-based reporting. - Cleans up related warnings! This is a follow-up of apache/airflow#43966 for main & Airflow 3 GitOrigin-RevId: 339bc7748156a4d099121092addb5af1da4e81e8
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 20, 2025
- Removes the `timer_unit_consistency` configuration option, standardizing all timer and timing metrics to milliseconds by default. - Updates metric loggers (e.g., Datadog, OpenTelemetry) to ensure uniform milliseconds-based reporting. - Cleans up related warnings! This is a follow-up of apache/airflow#43966 for main & Airflow 3 GitOrigin-RevId: 339bc7748156a4d099121092addb5af1da4e81e8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #39908
Changes:
metrics_consistency_onconfig withtimer_unit_consistencyfor better clarity!Falseso folks aren't caught by surprise.We should backport this to 2.11 and remove this setting from Airflow main
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.