-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Prepare docs for Nov 1st wave of providers #44011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
eladkal
commented
Nov 14, 2024
569940a to
76e4946
Compare
|
Hmm. Interesting thing - now we have circular dependency: compat -> standard , standard->compat ... which is generally fine but we might have some interesting CI issues because of that :) |
|
That will also mean @eladkal that we MUST release standard provider with this wave - otherwise common won't be installable. It's currently 0.0.1 - which I think migt be a good idea to keep it at 0.* until we migrate all things out from core? |
that is the plan. This wave is pretty much all or nothing. It's 0.0.1 till we make it "stable" by extracting everything. |
|
Very interesting error. Side effect of another test. Fix is coming. |
The grpc.Channel has been patched but not relased in the test_grpc.py and it could have caused other tests failing - when they were run later in the same interpreter. For example it failed in in apache#44011 in the apache#44011 (comment) Patching is now fixed via using fixtures.
|
The failure is fixed in #44029 |
Cool so no need to regenerate docs as the fix is only in a test |
The grpc.Channel has been patched but not relased in the test_grpc.py and it could have caused other tests failing - when they were run later in the same interpreter. For example it failed in in #44011 in the #44011 (comment) Patching is now fixed via using fixtures.
| ~~~~ | ||
|
|
||
| * ``Move bash operator to Standard provider (#42252)`` | ||
| * ``Purge existing SLA implementation (#42285)`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm this one is because https://github.com/apache/airflow/pull/42285/files#diff-8fa4fd0e9c359df89fde6c3043b13aa7d36d9f63aebc1744bffc43e00b158886L26 - i.e. removal of sla_miss documentation. This is a small thing and probably not worth reverting, but it looks like the providers affected (pagerduty, slack, smtp) will miss the sla_miss documetnation. Not a big deal, would be better to have a note instead that it wil only work in 2.0 - @ferruzzi -> not sure if this is worth the effort.
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed in a pretty detailed way. Gernerally approved, but there are few questions/comments
76e4946 to
4776b2b
Compare
The grpc.Channel has been patched but not relased in the test_grpc.py and it could have caused other tests failing - when they were run later in the same interpreter. For example it failed in in #44011 in the apache/airflow#44011 (comment) Patching is now fixed via using fixtures. GitOrigin-RevId: 77281399de2c0fed224e16047eaadd51c657b289
The grpc.Channel has been patched but not relased in the test_grpc.py and it could have caused other tests failing - when they were run later in the same interpreter. For example it failed in in #44011 in the apache/airflow#44011 (comment) Patching is now fixed via using fixtures. GitOrigin-RevId: 77281399de2c0fed224e16047eaadd51c657b289
The grpc.Channel has been patched but not relased in the test_grpc.py and it could have caused other tests failing - when they were run later in the same interpreter. For example it failed in in #44011 in the apache/airflow#44011 (comment) Patching is now fixed via using fixtures. GitOrigin-RevId: 77281399de2c0fed224e16047eaadd51c657b289