AIP-84: Migrating DELETE queued asset events for assets to fastAPI #44052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vatsrahul1001
requested review from
bbovenzi,
ephraimbuddy,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:API
vatsrahul1001
added
the
legacy api
2 tasks
1 task
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Nice, I'll do a more in depth review once the base branch has been merged.
| def delete_asset_queued_events( | ||
| uri: str, | ||
| session: Annotated[Session, Depends(get_session)], | ||
| before: str = Query(None), |
Member
There was a problem hiding this comment.
I think we can use directly DateTimeQuery or DateTimeQuery | None. (param validation should be done by the route)
| response = test_client.delete( | ||
| f"/public/assets/queuedEvent/{uri}", | ||
| ) | ||
|
|
Member
There was a problem hiding this comment.
Nice we could also check in the db that the record has actually been deleted.
Contributor
Author
|
closing in favor of #44138 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #42370
Dependent: #43934
Swagger Specs
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.