AIP-84: Migrating DELETE a queued asset events for DAG to fastAPI #44054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoghrajesh
requested review from
bbovenzi,
ephraimbuddy,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:API
Contributor
Author
|
Only last 2 commits are relevant |
amoghrajesh
added
the
legacy api
1 task
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Nice. A few suggestions, more in depth review when the base branch is merged and this is rebased. (but it's already close to mergeable I would say)
| ] | ||
| ), | ||
| ) | ||
| def delete_dag_asset_queued_event( |
Member
There was a problem hiding this comment.
Should go in asset endpoint.
| dag_id: str, | ||
| uri: str, | ||
| session: Annotated[Session, Depends(get_session)], | ||
| before: str = Query(None), |
Member
There was a problem hiding this comment.
Use the DateTimeQuery, validation and parsing of parameters should be done by the route. So downstream functions manipulated a validated input, and not a bare string.
rawwar
reviewed
Nov 17, 2024
|
|
||
|
|
||
| class QueuedEventResponse(BaseModel): | ||
| """Queued Event serializer for responses..""" |
Contributor
There was a problem hiding this comment.
Suggested change
| """Queued Event serializer for responses..""" | |
| """Queued Event serializer for responses.""" |
Contributor
Author
|
Closing in favour of #44130 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #42370
Migrating delete a queued asset events for DAG to fastAPI
Dependent on #43934
Same setup as #43934
Responses:
Legacy
FastAPI
With time filtering:
Legacy
FastAPI
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.