Add wait_policy option to EmrCreateJobFlowOperator. #44055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
vincbeck
reviewed
Nov 15, 2024
Contributor
vincbeck
left a comment
vincbeck
left a comment
There was a problem hiding this comment.
Could you cover this new use case in a unit test?
eladkal
reviewed
Nov 15, 2024
adrian-adikteev
changed the title
eladkal
reviewed
Nov 18, 2024
vin100bk
approved these changes
Nov 18, 2024
vincbeck
approved these changes
Nov 18, 2024
Contributor
|
Good job! I like that version |
eladkal
reviewed
Nov 18, 2024
eladkal
approved these changes
Nov 20, 2024
Contributor
Author
|
I'm not sure what's the next step here but from my side everything is ready. |
vincbeck
requested changes
Nov 21, 2024
Contributor
vincbeck
left a comment
vincbeck
left a comment
There was a problem hiding this comment.
Overall looks good! Just one nit and you do not a newsfragment for this change
Contributor
Author
|
Should be ready for merge |
Possible values: - None: No wait (default) - WaitPolicy.WAIT_FOR_COMPLETION: Previous behaviour when wait_for_completion was True - WaitPolicy.WAIT_FOR_STEPS_COMPLETION: New behaviour - wait for the cluster to terminate.
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when using
wait_for_complition=Trueit will trigger the node to only wait until the cluster is successfully launched.I added the option
wait_policyso that one can chose what waiter will be used.Possible values:
None: No wait (default)WaitPolicy.WAIT_FOR_COMPLETION: Previous behaviour whenwait_for_completionwasTrueWaitPolicy.WAIT_FOR_STEPS_COMPLETION: New behaviour - wait for the cluster to terminate.This is useful because it will eliminate the need to have an extra node in your DAG.