Fix special tests in the new workflow structure #44083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When apache#43979 there was a typo where inputs passed as test-groups were not passed to unit tests in "special-tests" case - because the "needs.build-info.outputs" were used instead. Unfortunately this is not caught by GitHub parsing the workflows, it will only signal it by having annotations of errors on the affected actions - missing needs.build-info entries are simply replaced by empty string.
potiuk
requested review from
eladkal,
gopidesupavan,
hussein-awala,
jedcunningham and
rawwar
eladkal
approved these changes
Nov 16, 2024
gopidesupavan
approved these changes
Nov 16, 2024
kandharvishnu
pushed a commit
to kandharvishnu/airflow
that referenced
this pull request
Nov 19, 2024
When apache#43979 there was a typo where inputs passed as test-groups were not passed to unit tests in "special-tests" case - because the "needs.build-info.outputs" were used instead. Unfortunately this is not caught by GitHub parsing the workflows, it will only signal it by having annotations of errors on the affected actions - missing needs.build-info entries are simply replaced by empty string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When #43979 there was a typo where inputs passed as test-groups were not passed to unit tests in "special-tests" case - because the "needs.build-info.outputs" were used instead.
Unfortunately this is not caught by GitHub parsing the workflows, it will only signal it by having annotations of errors on the affected actions - missing needs.build-info entries are simply replaced by empty string.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.