Revert "AIP-84: Migrating GET queued asset events for DAG to fastAPI … #44088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
bbovenzi,
ephraimbuddy,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:API
Member
Author
|
We need to revert that one - because bug of no error fixed in #44087 did not catch the API errors introduced in #43934 . @amoghrajesh - you will have to recreate the PR unfortunately. |
potiuk
force-pushed
the
revert-failed-tests
branch
from
6c2852a to
e34cb42
Compare
…pache#43934)" This reverts commit 3917730.
potiuk
force-pushed
the
revert-failed-tests
branch
from
e34cb42 to
a42cf9c
Compare
Contributor
There was a problem hiding this comment.
Copilot reviewed 5 out of 13 changed files in this pull request and generated no suggestions.
Files not reviewed (8)
- airflow/api_fastapi/core_api/openapi/v1-generated.yaml: Language not supported
- airflow/ui/openapi-gen/queries/common.ts: Evaluated as low risk
- airflow/ui/openapi-gen/requests/schemas.gen.ts: Evaluated as low risk
- airflow/api_fastapi/core_api/datamodels/assets.py: Evaluated as low risk
- tests/api_fastapi/core_api/routes/public/test_assets.py: Evaluated as low risk
- airflow/ui/openapi-gen/queries/prefetch.ts: Evaluated as low risk
- airflow/ui/openapi-gen/queries/queries.ts: Evaluated as low risk
- airflow/ui/openapi-gen/queries/suspense.ts: Evaluated as low risk
Lee-W
approved these changes
Nov 16, 2024
Member
|
now we have Copilot as reviewer 🤔 |
gopidesupavan
approved these changes
Nov 16, 2024
kandharvishnu
pushed a commit
to kandharvishnu/airflow
that referenced
this pull request
Nov 19, 2024
…pache#43934)" (apache#44088) This reverts commit 3917730.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…(#43934)"
This reverts commit 3917730.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.