AIP-84: Migrating GET one queued asset events for DAG to fastAPI #44128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoghrajesh
requested review from
bbovenzi,
ephraimbuddy,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:API
Contributor
Author
|
Only last commit is relevant |
amoghrajesh
added
the
legacy api
This was referenced Nov 18, 2024
Lee-W
approved these changes
Nov 18, 2024
Member
Lee-W
left a comment
Lee-W
left a comment
There was a problem hiding this comment.
left one nitpick. but overall looks good
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
pierrejeambrun
approved these changes
Nov 18, 2024
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Great, just one small update required, feel free to merge after
Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
amoghrajesh
requested review from
ashb,
eladkal and
o-nikolas
as code owners
amoghrajesh
force-pushed
the
AIP84-get-one-queued-event-for-dag-again
branch
from
389d09e to
449420c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #42370
Same setup as #44124 and dependent on #44124
Responses:
Legacy
FastAPI
With time filtering
Legacy
FastAPI
Swagger spec:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.