AIP-84 Get Mapped Task Instance Try Details #44206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kandharvishnu
requested review from
bbovenzi,
ephraimbuddy,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:API
rawwar
reviewed
Nov 20, 2024
tests/api_fastapi/core_api/routes/public/test_task_instances.py
Outdated
Show resolved
Hide resolved
rawwar
reviewed
Nov 20, 2024
tests/api_fastapi/core_api/routes/public/test_task_instances.py
Outdated
Show resolved
Hide resolved
rawwar
reviewed
Nov 20, 2024
tests/api_fastapi/core_api/routes/public/test_task_instances.py
Outdated
Show resolved
Hide resolved
rawwar
reviewed
Nov 20, 2024
tests/api_fastapi/core_api/routes/public/test_task_instances.py
Outdated
Show resolved
Hide resolved
rawwar
reviewed
Nov 20, 2024
tests/api_fastapi/core_api/routes/public/test_task_instances.py
Outdated
Show resolved
Hide resolved
rawwar
reviewed
Nov 20, 2024
kandharvishnu
force-pushed
the
AIP-84_get_mapped_task_instance_try_details
branch
from
921f1a8 to
5a34649
Compare
kandharvishnu
force-pushed
the
AIP-84_get_mapped_task_instance_try_details
branch
from
5a34649 to
09908c1
Compare
rawwar
reviewed
Nov 20, 2024
tests/api_fastapi/core_api/routes/public/test_task_instances.py
Outdated
Show resolved
Hide resolved
rawwar
reviewed
Nov 20, 2024
tests/api_fastapi/core_api/routes/public/test_task_instances.py
Outdated
Show resolved
Hide resolved
1 task
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Looking good overall beside @rawwar comments.
Contributor
Author
yes, removed the print statements |
rawwar
approved these changes
Nov 20, 2024
Contributor
|
Just noticed logical_date is missing in response model(TaskInstanceHistoryResponse). Is this intentional ? |
Contributor
Author
TaskInstanceHistoryResponse return |
Contributor
|
I saw the response Here and saw it had execution_date |
Contributor
Author
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
* adding get_mapped_task_instance_try_details * dummy change * revert dummy change * removing print statements --------- Co-authored-by: kandharvishnuu <148410552+kandharvishnuu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to: #42370