Skip to content

Conversation

@kaxil
Copy link
Member

@kaxil kaxil commented Nov 23, 2024

The changes added in #44271 require 3.16 as google.cloud.translate_v3.types.automl_translation was added in 3.16 - https://github.com/googleapis/google-cloud-python/blob/main/packages/google-cloud-translate/CHANGELOG.md

Without this it causes failures on main such as https://github.com/apache/airflow/actions/runs/11982463149/job/33410779346?pr=44295#step:7:5367

  ==================================== ERRORS ====================================
  __ ERROR collecting providers/tests/google/cloud/operators/test_translate.py ___
  ImportError while importing test module '/opt/airflow/providers/tests/google/cloud/operators/test_translate.py'.
  Hint: make sure your test modules/packages have valid Python names.
  Traceback:
  /usr/local/lib/python3.11/importlib/__init__.py:126: in import_module
      return _bootstrap._gcd_import(name[level:], package, level)
  providers/tests/google/cloud/operators/test_translate.py:23: in <module>
      from google.cloud.translate_v3.types import automl_translation
  E   ImportError: cannot import name 'automl_translation' from 'google.cloud.translate_v3.types' (/usr/local/lib/python3.11/site-packages/google/cloud/translate_v3/types/__init__.py)
  ----- generated xml file: /files/test_result-providers_google-postgres.xml -----
  =========================== short test summary info ============================
  ERROR providers/tests/google/cloud/operators/test_translate.py
  !!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
  ========================= 1 warning, 1 error in 39.33s =========================
  

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

The changes added in apache#44271 require 3.16 as `google.cloud.translate_v3.types.automl_translation` was added in 3.16 - https://github.com/googleapis/google-cloud-python/blob/main/packages/google-cloud-translate/CHANGELOG.md
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Nov 23, 2024
@kaxil kaxil merged commit 3c58e01 into apache:main Nov 23, 2024
@kaxil kaxil deleted the bump-google-translate branch November 23, 2024 03:42
@potiuk
Copy link
Member

potiuk commented Nov 23, 2024

NICE!.. Our test harness seems to work well :)

got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants